[
https://issues.apache.org/jira/browse/HBASE-21748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749591#comment-16749591
]
Zheng Hu commented on HBASE-21748:
----------------------------------
[~apurtell], Thanks for your patch, skimmed the patch. Adding an atomic
integer cellCount seems good. there are some points need to be care:
- I think we should throw an UnsupportedOperationException in
CellSkipListSet#size if the delegate is CSLM, for avoiding others to call
this time-consuming method in some read/write path without intention.
- for memstore#add, the cellCount should increment only when putting CSLM
successfully. for memstore#upsert, no need to increment the cellCount, but
need to decrement the cell count if we ensure to remove useless cell version.
Thanks.
> Port HBASE-21738 (Remove all the CLSM#size operation in our memstore because
> it's an quite time consuming.) to branch-1
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-21748
> URL: https://issues.apache.org/jira/browse/HBASE-21748
> Project: HBase
> Issue Type: Sub-task
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-21748-branch-1.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
