[ 
https://issues.apache.org/jira/browse/HBASE-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754607#comment-16754607
 ] 

Hadoop QA commented on HBASE-18837:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  5s{color} 
| {color:red} HBASE-18837 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.8.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18837 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12956651/HBASE-18837.v0.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/15760/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> HTableMultiplexer behavior during regions split
> -----------------------------------------------
>
>                 Key: HBASE-18837
>                 URL: https://issues.apache.org/jira/browse/HBASE-18837
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.1.2
>            Reporter: chausson
>            Assignee: kevin su
>            Priority: Minor
>         Attachments: HBASE-18837.v0.patch
>
>
> HTableMultiplexer class mentions following in the javadoc : "If any queue is 
> full, the HTableMultiplexer starts to drop the Put requests for that 
> particular queue."
> This could be improved by replacing following code in 
> HTableMultiplexer.resubmitFailedPut() method :
> {code:title=HTableMultiplexer}
> try {
>       succ = FlushWorker.this.getMultiplexer().put(tableName, failedPut, 
> retryCount);
> } finally {
>       FlushWorker.this.getRetryInQueue().decrementAndGet();
>       if (!succ) {
>               FlushWorker.this.getTotalFailedPutCount().incrementAndGet();
>       }
> }
> {code}
> With : 
> {code}
> try {
>       succ = FlushWorker.this.getMultiplexer().put(tableName, failedPut, 
> retryCount);
>       if (!succ) {
>               if (!resubmitFailedPut(ps, oldLoc)) {
>                       
> FlushWorker.this.getTotalFailedPutCount().incrementAndGet();
>               }
>       }
> } finally {
>       FlushWorker.this.getRetryInQueue().decrementAndGet();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to