[
https://issues.apache.org/jira/browse/HBASE-21688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756909#comment-16756909
]
Nihal Jain commented on HBASE-21688:
------------------------------------
[~vrodionov] Thanks for the patches.
I think the {{TestMasterWALManager}} testclass would fail with
[^HBASE-21688-branch-2.1-v1.patch]. (I have already ported this in our internal
branch and it had failed there).
The changes I had made in {{TestMasterWALManager.before()}} were as follows,
you may consider using them, if it looks fine:
{code:java}
- this.mwm = new MasterWalManager(this.masterServices);
+ this.mwm = new MasterWalManager(this.masterServices) {
+
+ @Override
+ Path getWALDirPath() throws IOException {
+ return walRootDir;
+ }
+
+ @Override
+ Path getWALDirectoryName(ServerName serverName) throws IOException {
+ return new Path(walRootDir,
+ AbstractFSWALProvider.getWALDirectoryName(serverName.toString()));
+ }
+ };
{code}
IMO the following change is redundant in {{MasterWalManager}}:
{code:java}
- FileStatus[] walDirForServerNames = FSUtils.listStatus(fs, walDirPath,
filter);
+ FileStatus[] walDirForServerNames =
FSUtils.listStatus(CommonFSUtils.getWALFileSystem(conf),
+ walDirPath, filter);
{code}
You should also be removing following javadoc string from {{WALEntryStream()}},
since we have dropped fs param in the patch:
{code:java}
* @param fs {@link FileSystem} to use to create {@link Reader} for this stream
{code}
> Address WAL filesystem issues
> -----------------------------
>
> Key: HBASE-21688
> URL: https://issues.apache.org/jira/browse/HBASE-21688
> Project: HBase
> Issue Type: Bug
> Components: Filesystem Integration, wal
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Priority: Major
> Labels: s3
> Fix For: 3.0.0
>
> Attachments: HBASE-21688-amend.2.patch, HBASE-21688-amend.patch,
> HBASE-21688-branch-2.1-v1.patch, HBASE-21688-v1.patch
>
>
> Scan and fix code base to use new way of instantiating WAL File System.
> https://issues.apache.org/jira/browse/HBASE-21457?focusedCommentId=16734688&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16734688
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
