[
https://issues.apache.org/jira/browse/HBASE-20693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757660#comment-16757660
]
Nihal Jain commented on HBASE-20693:
------------------------------------
Attached [^HBASE-20693.master.001.patch] which refactors {{rest.jsp}} and
{{thrift.jsp}} and extracts header and footer out of them. Also, fixed
following typo in thrift.jsp.
{code:java}
- <td><%= VersionInfo.getVersion() %>, r<%= VersionInfo.getRevision() %></td>
+ <td><%= VersionInfo.getVersion() %>, revision=<%= VersionInfo.getRevision()
%></td>
{code}
Please review. Ping [~tianjingyun], [~zghaobac], [~stack].
> Refactor rest and thrift jsp's and extract header and footer
> ------------------------------------------------------------
>
> Key: HBASE-20693
> URL: https://issues.apache.org/jira/browse/HBASE-20693
> Project: HBase
> Issue Type: Improvement
> Reporter: Nihal Jain
> Assignee: Nihal Jain
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20693.master.001.patch, rest_home_after_patch.png,
> thrift_home_after_patch.png, thrift_log_level_after_patch.png,
> thrift_log_level_before_patch.png
>
>
> Log Level page design was changed to include header and footers in
> HBASE-20577. Since, thrift and rest do not have header and footer jsp's, the
> log level page will be as it were before HBASE-20577 i.e without the
> navigation bar. This JIRA will refactor rest and thrift and extract
> 'header.jsp' and 'footer.jsp' from them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
