[ 
https://issues.apache.org/jira/browse/HBASE-21817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757933#comment-16757933
 ] 

Sean Busbey commented on HBASE-21817:
-------------------------------------

In the case of dataloss we need to ensure the operator is aware of what 
happened and that they can get the specific file.

{code}

+  /** Tries to replay a single WAL - useful for debugging. */
{code}

-1 on this. No more rando main methods littering the code base; they're too 
hard to track and downstream folks inevitably try using them. If this 
functionality isn't already in wal player or wal printer then it should be an 
option or a similarly scoped tool.

> skip records with corrupted cells in WAL splitting
> --------------------------------------------------
>
>                 Key: HBASE-21817
>                 URL: https://issues.apache.org/jira/browse/HBASE-21817
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Critical
>         Attachments: HBASE-21817.patch
>
>
> See HBASE-21601 for context.
> I looked at the code a bit but it will take a while to understand, so for now 
> I'm going to mitigate it by skipping such records. Given that this record is 
> bogus, and the lengths are intact, for this scenario it's safe to do so. 
> However, it's possible I guess to have a bug where skipping such record would 
> lead to data loss. Regardless, failure to split the WAL will lead to even 
> more data loss in this case so it should be ok to handle errors where the 
> structure is correct but cells are corrupted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to