[
https://issues.apache.org/jira/browse/HBASE-21817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760197#comment-16760197
]
Sergey Shelukhin edited comment on HBASE-21817 at 2/4/19 8:42 PM:
------------------------------------------------------------------
Upon further examination we already have a path for handling corrupted WALs so
I will just use that.
The above could still be done in a separate JIRA ("splitting" the WAL in HBCK
to separate good and bad records), however this case is rather obscure so I'm
not sure it's worth it, unless we have a release without the fix to the
original issue that writes such WAL.
was (Author: sershe):
Upon further examination we already have a path for handling corrupted WALs so
I will just use that.
The above could still be done in a separate JIRA ("splitting" the WAL in HBCK
to separate good and bad records), however this case is rather obscure so I'm
not sure it's worth it.
> skip records with corrupted cells in WAL splitting
> --------------------------------------------------
>
> Key: HBASE-21817
> URL: https://issues.apache.org/jira/browse/HBASE-21817
> Project: HBase
> Issue Type: Bug
> Components: wal
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Critical
> Attachments: HBASE-21817.01.patch, HBASE-21817.patch
>
>
> See HBASE-21601 for context.
> I looked at the code a bit but it will take a while to understand, so for now
> I'm going to mitigate it by skipping such records. Given that this record is
> bogus, and the lengths are intact, for this scenario it's safe to do so.
> However, it's possible I guess to have a bug where skipping such record would
> lead to data loss. Regardless, failure to split the WAL will lead to even
> more data loss in this case so it should be ok to handle errors where the
> structure is correct but cells are corrupted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
