[
https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229944#comment-13229944
]
Phabricator commented on HBASE-5542:
------------------------------------
sc has commented on the revision "HBASE-5542 [jira] Unify
HRegion.mutateRowsWithLocks() and HRegion.processRow()".
Thanks for the review.
>What do you think if I take your patch and try to fit doMiniBatchPut into it
and then update the patch accordingly (if needed) - before we commit the patch?
Sure. Please make it better before you check it in.
But you will still go through your major work in the other JIRA, right?
https://issues.apache.org/jira/browse/HBASE-5565
We will do the review over there. There are too much information in this
thread.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:238 Sure. Let
me change it to 1 minute.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:4309 Thanks.
That's a good catch!
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:4286 I see.
We can still make remember some state after calling preProcess() and change the
output of getRowsToLock(). I like making getRowsToLock() returns the rows
rather than preProcess() because it seems more clear to me.
REVISION DETAIL
https://reviews.facebook.net/D2217
> Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
> ------------------------------------------------------------
>
> Key: HBASE-5542
> URL: https://issues.apache.org/jira/browse/HBASE-5542
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.96.0
>
> Attachments: HBASE-5542.D2217.1.patch, HBASE-5542.D2217.10.patch,
> HBASE-5542.D2217.11.patch, HBASE-5542.D2217.12.patch,
> HBASE-5542.D2217.13.patch, HBASE-5542.D2217.14.patch,
> HBASE-5542.D2217.2.patch, HBASE-5542.D2217.3.patch, HBASE-5542.D2217.4.patch,
> HBASE-5542.D2217.5.patch, HBASE-5542.D2217.6.patch, HBASE-5542.D2217.7.patch,
> HBASE-5542.D2217.8.patch, HBASE-5542.D2217.9.patch, HBASE-5542.txt
>
>
> mutateRowsWithLocks() does atomic mutations on multiple rows.
> processRow() does atomic read-modify-writes on a single row.
> It will be useful to generalize both and have a
> processRowsWithLocks() that does atomic read-modify-writes on multiple rows.
> This also helps reduce some redundancy in the codes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
