[ 
https://issues.apache.org/jira/browse/HBASE-21808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762964#comment-16762964
 ] 

Sean Busbey commented on HBASE-21808:
-------------------------------------

bq. Would this change be useful for branch-1 too?

it probably would be useful in branch-1; that was my original plan. I can't 
recall what issue I ran into when I tried but it was enough that I moved on.

{quote}
bq. IIRC back when we were first adding jdk8 support we could run but not build 
and we just put that in a note on the section

I did some testing with JDK 11 late last year and the whole stack (zookeeper, 
hadoop, hbase, and in our case phoenix) exhibited a surprising number of unit 
test failures at each layer.  Zookeeper results were particularly surprising, 
and concerning. I would hesitate to claim everything just works given test 
failures at every layer, but that could be the case. There is just no way to 
verify it.
{quote}

Oh sorry if I wasn't clear. IIRC we specifically went through the integration 
tests including ITBLL when running on jdk8 after building with jdk7. I didn't 
mean to imply that "if it starts it ships" was the bar.

> Ensure we can build with JDK11 targetting JDK8
> ----------------------------------------------
>
>                 Key: HBASE-21808
>                 URL: https://issues.apache.org/jira/browse/HBASE-21808
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, community, java
>    Affects Versions: 3.0.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Major
>             Fix For: 3.0.0, 2.3.0
>
>         Attachments: HBASE-21808.0.patch
>
>
> When folks "install a JDK" wether they get JDK11 now will depend on the 
> platform (e.g. from homebrew you will get jdk11). For new contributors this 
> results in confusing errors on first run.
> Make it so that a non-release build using JDK11 and using our default 
> compiler source/target versions of JDK8 can complete.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to