[ 
https://issues.apache.org/jira/browse/HBASE-21860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763997#comment-16763997
 ] 

Wellington Chevreuil commented on HBASE-21860:
----------------------------------------------

Hey [~stack], [~busbey],

Yeah, as [~busbey] mentioned, all branches would benefit from this, with 
branches > 2.0 being more critical, as if multiwal is set as 
"hbase.wal.provider" and no value is explicitly defined on 
"hbase.wal.meta_provider", multiwal will be the one picked for meta as well. 
For branches < 2.0, the issue is less probable, unless users define multiwal to 
"hbase.wal.meta_provider" (if "hbase.wal.meta_provider" is not set, it will 
default to filesystem). This patch does not apply to branches 2.x and 1.x. I 
will upload additional patches for each of these branches later.



> WALFactory should switch to default provider if multiwal provider is defined 
> for meta wal (Per suggestions on HBASE-21843) 
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-21860
>                 URL: https://issues.apache.org/jira/browse/HBASE-21860
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>            Reporter: Wellington Chevreuil
>            Assignee: Wellington Chevreuil
>            Priority: Critical
>         Attachments: HBASE-21860.master.001.patch
>
>
> Following discussions on HBASE-21843, one of the suggestion was to make wal 
> provider for meta wal switch to default provider if multi wal is defined as 
> the target provider. Quoting [~busbey]: 
> {quote}
> I don't think it's a good idea to revert HBASE-20856. the principles of that 
> issue are still sound.
> We already have logic somewhere for the AsyncDFS based WAL that falls back to 
> the default if something goes wrong with the needed HDFS hooks. Can we do 
> something similar for the region grouping provider and make the check 
> something like "did you ask for a provider for meta"?
> {quote}
> Am uploading a patch that switches to default whenever WALFactory finds 
> multiwal provider is defined for meta wal (either explicitly by defining 
> "hbase.wal.meta_provider", or indirectly, by loading what is in 
> "hbase.wal.provider")



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to