[
https://issues.apache.org/jira/browse/HBASE-21817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766328#comment-16766328
]
Sean Busbey commented on HBASE-21817:
-------------------------------------
{code}
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
index 66795978f2..7436dfe5f1 100644
@@ -144,6 +144,7 @@ public class WALSplitter {
144 144
145 // if we limit the number of writers opened for sinking recovered
edits 145 // if we limit the number of writers opened for sinking
recovered edits
146 private final boolean splitWriterCreationBounded; 146
private final boolean splitWriterCreationBounded;
147 private final boolean skipErrors;
147 148
148 public final static String SPLIT_WRITER_CREATION_BOUNDED =
"hbase.split.writer.creation.bounded"; 149 public final static String
SPLIT_WRITER_CREATION_BOUNDED = "hbase.split.writer.creation.bounded";
149 150
@@ -174,9 +175,10 @@ public class WALSplitter {
174 if(splitWriterCreationBounded){ 175
if(splitWriterCreationBounded){
175 outputSink = new BoundedLogWriterCreationOutputSink( 176
outputSink = new BoundedLogWriterCreationOutputSink(
176 controller, entryBuffers, numWriterThreads); 177
controller, entryBuffers, numWriterThreads);
177 }else { 178 } else {
178 outputSink = new LogRecoveredEditsOutputSink(controller,
entryBuffers, numWriterThreads); 179 outputSink = new
LogRecoveredEditsOutputSink(controller, entryBuffers, numWriterThreads);
179 } 180 }
181 this.skipErrors = conf.getBoolean("hbase.hlog.split.skip.errors",
SPLIT_SKIP_ERRORS_DEFAULT);
180 } 182 }
{code}
This part is unneeded now I think?
> handle corrupted cells like other corrupted WAL cases
> -----------------------------------------------------
>
> Key: HBASE-21817
> URL: https://issues.apache.org/jira/browse/HBASE-21817
> Project: HBase
> Issue Type: Bug
> Components: wal
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Critical
> Attachments: HBASE-21817.01.patch, HBASE-21817.02.patch,
> HBASE-21817.03.patch, HBASE-21817.patch
>
>
> See HBASE-21601 for context.
> I looked at the code a bit but it will take a while to understand, so for now
> I'm going to mitigate it by handling such cases like any other corrupted WAL
> (via either skipErrors or CorruptedHLog exception)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
