[
https://issues.apache.org/jira/browse/HBASE-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230665#comment-13230665
]
stack commented on HBASE-5559:
------------------------------
Sujee Since you are learning how to contrib., how about your figuring how to
add a test for your change. Your life testing might be easier if you made
getSplits static and passed in this.presplitRegions as an argument (you can
have getSplits call it). In your test you'd exercise the different
combinations passing a this.presplitRegions with no elements and then with a
few different values for R?
Patch is looking good otherwise.
> --presplit option creates a first split with rowkey-end=0
> ---------------------------------------------------------
>
> Key: HBASE-5559
> URL: https://issues.apache.org/jira/browse/HBASE-5559
> Project: HBase
> Issue Type: Bug
> Components: util
> Reporter: Sujee Maniyam
> Assignee: Sujee Maniyam
> Priority: Trivial
> Labels: benchmark
> Attachments: 5559_v1.patch, HBASE-5559-v2.patch
>
>
> HBASE-4440 adds a 'presplit' option to PerformanceEvaluation utility.
> when the splits are generated, the first split has row-end-key=0 (zero).
> Hence this split doesn't get any data.
> For example,
> if total keyspace is 100, and splits requested are 5,
> generated splits => [0, 20, 40, 60, 80]
> it should be => [20, 40, 60, 80, 100]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
