[
https://issues.apache.org/jira/browse/HBASE-21866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767601#comment-16767601
]
Xu Cang commented on HBASE-21866:
---------------------------------
[~nihaljain.cs]
The reason I did that is because this JIRA:
HBASE-20666 Unsuccessful table creation leaves entry in hbase:rsgroup table
The "#postDeleteTable" helps to cleanup rsgroup meta data.
The code is in #postDeleteTable in RSGroupAdminEndpoint.java.
I agree with you it seems a bit weird to call postDeleteTable in createTable
rollback method. One possible way to make it better is to rename this method:
postDeleteTable to something else.
Regarding [~water]'s patch. I think the logic is correct and LGTM. You might
want to fix the minor indentation issue in the patch. Thanks
> Do not move the table to null rsgroup when creating a existing table
> --------------------------------------------------------------------
>
> Key: HBASE-21866
> URL: https://issues.apache.org/jira/browse/HBASE-21866
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
> Reporter: Xiang Li
> Assignee: Xiang Li
> Priority: Major
> Attachments: HBASE-21866.master.000.patch
>
>
> By using the latest HBase master branch, the bug could be re-produced as:
> # create 't1', 'cf1'
> # create 't1', 'cf1'
> The following message is logged into HMaster's log:
> {code}
> INFO [PEWorker-12] rsgroup.RSGroupAdminServer: Moving table t1 to RSGroup
> null
> {code}
> This is a wrong action that we should keep t1 as where it originally is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
