[ 
https://issues.apache.org/jira/browse/HBASE-21866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768708#comment-16768708
 ] 

Xu Cang commented on HBASE-21866:
---------------------------------

The patch looks really good to me. 
One nit:
getException().getCause().getClass() 
Can you double check if this will not cause nullPointerException in any chance? 
I think you might want to call  #hasException first.


> Do not move the table to null rsgroup when creating an existing table
> ---------------------------------------------------------------------
>
>                 Key: HBASE-21866
>                 URL: https://issues.apache.org/jira/browse/HBASE-21866
>             Project: HBase
>          Issue Type: Bug
>          Components: proc-v2, rsgroup
>            Reporter: Xiang Li
>            Assignee: Xiang Li
>            Priority: Major
>         Attachments: HBASE-21866.master.000.patch, 
> HBASE-21866.master.001.patch
>
>
> By using the latest HBase master branch, the bug could be re-produced as:
>  # create 't1', 'cf1'
>  # create 't1', 'cf1'
> The following message is logged into HMaster's log:
> {code}
> INFO  [PEWorker-12] rsgroup.RSGroupAdminServer: Moving table t1 to RSGroup 
> null
> {code}
> This is a wrong action and instead, we should keep t1 as where it originally 
> is.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to