[
https://issues.apache.org/jira/browse/HBASE-21866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770788#comment-16770788
]
Xiang Li commented on HBASE-21866:
----------------------------------
Got you [~nihaljain.cs] [~xucang], thanks for the comments!
Please let me know what else I can do for this JIRA?
By the way, your discussion reminded me of one possible improvement that could
be made:
{code:java}
// check that we have at least 1 CF
if (tableDescriptor.getColumnFamilyCount() == 0) {
setFailure("master-create-table", new *DoNotRetryIOException*("Table " +
getTableName().toString() + " should have at least one column
family."));
return false;
}
{code}
DoNotRetryIOException seems quite common, and not specific. We could only check
the message within this exception if we would like to response to that
condition specifically.
> Do not move the table to null rsgroup when creating an existing table
> ---------------------------------------------------------------------
>
> Key: HBASE-21866
> URL: https://issues.apache.org/jira/browse/HBASE-21866
> Project: HBase
> Issue Type: Bug
> Components: proc-v2, rsgroup
> Reporter: Xiang Li
> Assignee: Xiang Li
> Priority: Major
> Attachments: HBASE-21866.branch-1.000.patch,
> HBASE-21866.master.000.patch, HBASE-21866.master.001.patch,
> HBASE-21866.master.002.patch, HBASE-21866.master.003.patch
>
>
> By using the latest HBase master branch, the bug could be re-produced as:
> # create 't1', 'cf1'
> # create 't1', 'cf1'
> The following message is logged into HMaster's log:
> {code}
> INFO [PEWorker-12] rsgroup.RSGroupAdminServer: Moving table t1 to RSGroup
> null
> {code}
> This is a wrong action and instead, we should keep t1 as where it originally
> is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
