[
https://issues.apache.org/jira/browse/HBASE-20587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773100#comment-16773100
]
Josh Elser commented on HBASE-20587:
------------------------------------
No qualms here, thanks for picking it up!
Your first patch looks OK, but seems like might have caused some of those test
failures. I'm sure you're on that already.
I see you were fixing some other style/static-analysis things while you were in
some files. Bloats the patch a little, but probably better long term. Thanks
for having an eye out for them.
> Replace Jackson with shaded thirdparty gson
> -------------------------------------------
>
> Key: HBASE-20587
> URL: https://issues.apache.org/jira/browse/HBASE-20587
> Project: HBase
> Issue Type: Bug
> Components: dependencies
> Reporter: Josh Elser
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-20587-v1.patch, HBASE-20587.001.patch
>
>
> HBASE-20582 got me looking at how we use Jackson. It appears that we moved
> some JSON code from hbase-server into hbase-common via HBASE-19053. But,
> there seems to be no good reason why this code should live there and not in
> hbase-http instead. Keeping Jackson off the user's classpath is a nice goal.
> FYI [~appy], [~mdrob]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
