[
https://issues.apache.org/jira/browse/HBASE-20724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776459#comment-16776459
]
Duo Zhang commented on HBASE-20724:
-----------------------------------
And for [~lhofhansl], the basic problem here is that, we rely on replaying
compaction marker to delete the compacted files when opening a region. And we
will not flush the compaction marker to HFile when flushing a region, but we
will delete the WAL file after the flush, which means that a useful compaction
marker could be removed... So here the solution is to also write the compaction
to hfile.
Oh, [~zghaobac] maybe there is another problem, that the file which is
generated by a compaction is compacted again, and then is deleted before we
remove the previous compacted files? Then after region reopen, the previous
compacted files can not be removed...
> Sometimes some compacted storefiles are still opened after region failover
> --------------------------------------------------------------------------
>
> Key: HBASE-20724
> URL: https://issues.apache.org/jira/browse/HBASE-20724
> Project: HBase
> Issue Type: Bug
> Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0
> Reporter: Francis Liu
> Assignee: Guanghao Zhang
> Priority: Critical
> Attachments: HBASE-20724.master.001.patch,
> HBASE-20724.master.002.patch, HBASE-20724.master.003.patch,
> HBASE-20724.master.004.patch, HBASE-20724.master.005.patch,
> HBASE-20724.master.006.patch, HBASE-20724.master.007.patch,
> HBASE-20724.master.008.patch, HBASE-20724.master.009.patch
>
>
> It is important that compacted storefiles of a given compaction execution are
> wholly opened or archived to insure data consistency. ie a storefile
> containing delete tombstones can be archived while older storefiles
> containing cells that were supposed to be deleted are left unarchived thereby
> undeleting those cells.
> When a server fails compaction markers (in the wal edit) are used to
> determine which storefiles are compacted and should be excluded during region
> open (during failover). But the WALs containing compaction markers can be
> prematurely archived even though there are still compacted storefiles for
> that particular compaction event that hasn't been archived yet. Thus losing
> compaction information that needs to be replayed in the event of an RS crash.
> This is because hlog archiving logic only keeps track of flushed storefiles
> and not compacted ones.
> https://issues.apache.org/jira/browse/HBASE-20704?focusedCommentId=16507680&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16507680
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
