[ https://issues.apache.org/jira/browse/HBASE-21963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779998#comment-16779998 ]
Zach York commented on HBASE-21963: ----------------------------------- [~taklwu] It looks good! I would suggest changing the variable names to be a bit more descriptive to signify if the check has succeeded or failed: CHECKSUM -> CHECKSUM_OK or CHECKSUM_PASSED > Add a script for building and verifying release candidate > --------------------------------------------------------- > > Key: HBASE-21963 > URL: https://issues.apache.org/jira/browse/HBASE-21963 > Project: HBase > Issue Type: Test > Components: release, scripts > Affects Versions: 3.0.0, 2.1.3 > Reporter: Tak Lon (Stephen) Wu > Assignee: Tak Lon (Stephen) Wu > Priority: Minor > Attachments: HBASE-21963.master.001.patch, > HBASE-21963.master.002.patch > > > During the release vote for HBase 2.1.3RC1, a driver/helper script was > mentioned and can potentially help contributors prepare to vote for a release > candidate. As recommended, we decided to move toward this tool to under > {{dev-support/}} > Here the driver script provides the following automation: > 1. Import and check publisher key(s) > 2. Checksum of sources and binaries > 3. Signature of sources and binaries > 4. Rat check > 5. Built from source > 6. Verify unit tests > {code} > # example usage > $ bash dev-support/hbase-vote.sh -s > https://dist.apache.org/repos/dist/dev/hbase/hbase-1.5.0RC2/ > $ bash dev-support/hbase-vote.sh -h > hbase-vote. A script for standard vote which verifies the following items > 1. Checksum of sources and binaries > 2. Signature of sources and binaries > 3. Rat check > 4. Built from source > 5. Unit tests > Usage: hbase-vote.sh -s | --source <url> [-k | --key <signature>] [-f | > --keys-file-url <url>] > hbase-vote.sh -h | --help > -h | --help Show this screen. > -s | --source '<url>' A URL pointing to the release candidate > sources and binaries > e.g. > https://dist.apache.org/repos/dist/dev/hbase/hbase-<version>RC0/ > -k | --key '<signature>' A signature of the public key, e.g. 9AD2AE49 > -f | --keys-file-url '<url>' the URL of the key file, default is > http://www.apache.org/dist/hbase/KEYS > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)