[
https://issues.apache.org/jira/browse/HBASE-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231732#comment-13231732
]
Phabricator commented on HBASE-5521:
------------------------------------
tedyu has commented on the revision "HBASE-5521 [jira] Move
compression/decompression to an encoder specific encoding context".
Good progress.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java:330
Extra empty line.
src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java:55
Can 'contain returning results' be explained a little more ?
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:1624 'to seek
back' can be replaced with 'backward'
src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java:38
'compress' -> 'compresses'
src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java:60
Since compression is optional, should this method be named
encodeKeyValuesFollowedByOptionalCompression :-)
src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java:122
Would createDataBlockEncodingContext be a better name ?
src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java:127
'an encoder'
src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java:200
Are this javadoc and method name consistent with what line 212 returns ?
src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultEncodingContext.java:64
Please add javadoc for the parameters
src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultEncodingContext.java:133
Add headerBytes to @param
src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java:208
'decoding' -> 'compression'
src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultEncodingContext.java:156
Please add @Override for methods in the interface.
REVISION DETAIL
https://reviews.facebook.net/D2097
> Move compression/decompression to an encoder specific encoding context
> ----------------------------------------------------------------------
>
> Key: HBASE-5521
> URL: https://issues.apache.org/jira/browse/HBASE-5521
> Project: HBase
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HBASE-5521.1.patch, HBASE-5521.D2097.1.patch,
> HBASE-5521.D2097.2.patch, HBASE-5521.D2097.3.patch, HBASE-5521.D2097.4.patch,
> HBASE-5521.D2097.5.patch, HBASE-5521.D2097.6.patch, HBASE-5521.D2097.7.patch
>
>
> As part of working on HBASE-5313, we want to add a new columnar
> encoder/decoder. It makes sense to move compression to be part of
> encoder/decoder:
> 1) a scanner for a columnar encoded block can do lazy decompression to a
> specific part of a key value object
> 2) avoid an extra bytes copy from encoder to hblock-writer.
> If there is no encoder specified for a writer, the HBlock.Writer will use a
> default compression-context to do something very similar to today's code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
