[
https://issues.apache.org/jira/browse/HBASE-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231733#comment-13231733
]
stack commented on HBASE-5533:
------------------------------
Those metrics look beautiful.
NamedThreadFactory overlaps with functionality in the (badly named)
util.Threads class. You might check it out to make sure we're not duplicating
facility.
No need of these' + * Copyright 2010 The Apache Software Foundation' lines when
you are adding headers.
TestMetricsHistogram is missing license header.
Use something like
http://hadoop.apache.org/common/docs/current/api/org/apache/hadoop/util/StringUtils.html#limitDecimalTo2%28double%29
when you are in RegionServerMetrics#toString outputting your new values else
they could go ugly with lots of decimal places (see your screen shot).
Fix the minors above and lets get it in. Good stuff Shaneal.
> Add more metrics to HBase
> -------------------------
>
> Key: HBASE-5533
> URL: https://issues.apache.org/jira/browse/HBASE-5533
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.94.0
> Reporter: Shaneal Manek
> Assignee: Shaneal Manek
> Priority: Minor
> Attachments: BlockingQueueContention.java, HBASE-5533-0.92-v4.patch,
> TimingOverhead.java, hbase-5533-0.92.patch, hbase5533-0.92-v2.patch,
> hbase5533-0.92-v3.patch, histogram_web_ui.png
>
>
> To debub/monitor production clusters, there are some more metrics I wish I
> had available.
> In particular:
> - Although the average FS latencies are useful, a 'histogram' of recent
> latencies (90% of reads completed in under 100ms, 99% in under 200ms, etc)
> would be more useful
> - Similar histograms of latencies on common operations (GET, PUT, DELETE)
> would be useful
> - Counting the number of accesses to each region to detect hotspotting
> - Exposing the current number of HLog files
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
