[
https://issues.apache.org/jira/browse/HBASE-21969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782015#comment-16782015
]
Hudson commented on HBASE-21969:
--------------------------------
Results for branch branch-2
[build #1719 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1719/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1719//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1719//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1719//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1719//console].
> Improve the update of destination rsgroup of
> RSGroupInfoManagerImpl#moveTables()
> ---------------------------------------------------------------------------------
>
> Key: HBASE-21969
> URL: https://issues.apache.org/jira/browse/HBASE-21969
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
> Reporter: Xiang Li
> Assignee: Xiang Li
> Priority: Minor
> Fix For: 3.0.0, 2.3.1, 1.5.1
>
> Attachments: HBASE-21969.branch-1.000.patch,
> HBASE-21969.branch-2.000.patch, HBASE-21969.master.000.patch,
> HBASE-21969.master.001.patch
>
>
> RSGroupInfoManagerImpl#moveTables() has the following code:
> {code}
> for (TableName tableName : tableNames) {
> ....
> if (groupName != null) {
> RSGroupInfo dst = new RSGroupInfo(newGroupMap.get(groupName));
> dst.addTable(tableName);
> newGroupMap.put(dst.getName(), dst);
> }
> }
> {code}
> It is to add the tables to "dst" (the destination rsgroup) and put it back to
> newGroupMap to replace the old RSGroupInfo instance in the map.
> The current logic allocates a new RSGroupInfo instance and calls put
> operation of map for each table to move, which is not needed and causes a lot
> of objects to be allocated (the constructor of RSGroupInfo allocates 2
> TreeSets).
> The logic could be improved as: allocate a new RSGroupInfo only once, add all
> tables, and put it into the map.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
