[
https://issues.apache.org/jira/browse/HBASE-21915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783688#comment-16783688
]
Josh Elser commented on HBASE-21915:
------------------------------------
{quote}Was thinking of reverting this patch from branch-2.0 or what you think?
Change our matrix to drop 2.6.1-2.6.3 hadoop? Thanks.
{quote}
Argh! Hadoop, the present that keeps on giving :). Yeah, I didn't realize that
I'd have to do this via reflection.
I have zero qualms in dropping those old Hadoop versions (I hope no one is
actually still on any of these). I am also OK if you want to revert for now
because I don't have the cycles to drop current stuff and fix it.
> FileLink$FileLinkInputStream doesn't implement CanUnbuffer
> ----------------------------------------------------------
>
> Key: HBASE-21915
> URL: https://issues.apache.org/jira/browse/HBASE-21915
> Project: HBase
> Issue Type: Bug
> Components: Filesystem Integration
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.4
>
> Attachments: HBASE-21915.001.patch, HBASE-21915.002.patch
>
>
> FileLinkInputStream is an InputStream which handles the indirection of where
> the real HFile lives. This implementation is wrapped via
> FSDataInputStreamWrapper and is transparent when it's being used by a caller.
> Often, we have an FSDataInputStreamWrapper wrapping a FileLinkInputStream
> which wraps an FSDataInputStream.
> The problem is that FileLinkInputStream does not implement the
> \{{CanUnbuffer}} interface, which means that the underlying
> {{FSDataInputStream}} for the HFile the link refers to doesn't get
> {{unbuffer()}} called on it. This can cause an open Socket to hang around, as
> described in HBASE-9393.
> Both [~wchevreuil] and myself have run into this, each for different users.
> We think the commonality as to why these users saw this (but we haven't run
> into it on our own) is that it requires a very large snapshot to be brought
> into a new system. Big kudos to [~esteban] for his help in diagnosing this as
> well!
> If this analysis is accurate, it would affect all branches.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
