[ 
https://issues.apache.org/jira/browse/HBASE-21949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783964#comment-16783964
 ] 

Guanghao Zhang commented on HBASE-21949:
----------------------------------------

{quote}bq. IMHO, I prefer to the solution when finding the port conflict,just 
ignore and pass this sub-test,because the expect port has no number releation 
with the actual port 
{quote}
Yes. When there are bindException, it is hard to add a assert check for port.
{quote}bq.what you mean is that:*assertTrue((defaultClientPort + j) <= 
clientPortListInCluster.get(i).intValue())* ?
{quote}
Now it always choose a bigger port by +1 when catch BindException.

> Fix flaky test 
> TestHBaseTestingUtility.testMiniZooKeeperWithMultipleClientPorts
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-21949
>                 URL: https://issues.apache.org/jira/browse/HBASE-21949
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Guanghao Zhang
>            Assignee: maoling
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0, 2.3.0
>
>         Attachments: HBASE-21949-branch-2.2.patch
>
>
> Found this when run ut for branch-2.2. It is easy to port conflict.
> TestHBaseTestingUtility.testMiniZooKeeperWithMultipleClientPorts:299 
> expected:<8889> but was:<8888>



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to