[
https://issues.apache.org/jira/browse/HBASE-21959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789364#comment-16789364
]
Wellington Chevreuil commented on HBASE-21959:
----------------------------------------------
Thanks for the help reviewing and getting this committed, [~xucang]! I had just
uploaded a branch-1 patch. Since *CompactionTool* class is member of
*org.apache.hadoop.hbase.regionserver* package in *hbase-server* module, I had
placed *TestCompactionTool* on the corresponding test folder. Apart from that,
didn't have major trouble in converting this patch. Let me know if you have any
further suggestions/concerns.
> CompactionTool should close the store it uses for compacting files, in order
> to properly archive compacted files.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-21959
> URL: https://issues.apache.org/jira/browse/HBASE-21959
> Project: HBase
> Issue Type: Bug
> Components: tooling
> Reporter: Wellington Chevreuil
> Assignee: Wellington Chevreuil
> Priority: Major
> Attachments: HBASE-21959-branch-1-001.patch,
> HBASE-21959-master-001.patch, HBASE-21959-master-002.patch,
> HBASE-21959-master-003.patch
>
>
> While using CompactionTool to offload RSes, noticed compacted files were
> never archived from original region dir, causing the space used by the region
> to actually double. Going through its compaction related code on HStore,
> which is used by CompactionTool for performing compactions, found out what
> that compacted files archiving happens mainly while closing the HStore
> instance. CompactionTool is never explicitly closing its HStore instance, so
> adding a simple patch that properly close the store.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
