[
https://issues.apache.org/jira/browse/HBASE-21895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794286#comment-16794286
]
Kevin Risden edited comment on HBASE-21895 at 3/16/19 3:10 PM:
---------------------------------------------------------------
{quote}And the compile is also failed? Now we enable error prone by default
after the patch?
{quote}
Hmmm errorprone is still in a profile. Not sure why it was triggered by default
unless that profile is enabled during the yetus jobs.
Looks like errorprone is enabled as a profile by default in yetus
(dev-support/hbase-personality.sh line 170):
From
[https://builds.apache.org/job/PreCommit-HBASE-Build/16392/artifact/patchprocess/patch-compile-root.txt]
{code:java}
/usr/share/maven/bin/mvn --batch-mode
-Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/yetus-m2/hbase-master-patch-1
-DHBasePatchProcess -PerrorProne clean test-compile -DskipTests=true
{code}
So yes it will cause a compilation failure for yetus. If you are a developer
locally, the errorprone profile is not enabled by default.
was (Author: risdenk):
{quote}And the compile is also failed? Now we enable error prone by default
after the patch?
{quote}
Hmmm it errorprone is still in a profile. Not sure why it was triggered by
default unless that profile is enabled during the yetus jobs.
Looks like errorprone is enabled as a profile by default in yetus
(dev-support/hbase-personality.sh line 170):
From
[https://builds.apache.org/job/PreCommit-HBASE-Build/16392/artifact/patchprocess/patch-compile-root.txt]
{code:java}
/usr/share/maven/bin/mvn --batch-mode
-Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/yetus-m2/hbase-master-patch-1
-DHBasePatchProcess -PerrorProne clean test-compile -DskipTests=true
{code}
So yes it will cause a compilation failure for yetus. If you are a developer
locally, the errorprone profile is not enabled by default.
> Take more care on the error prone plugin and warnings
> -----------------------------------------------------
>
> Key: HBASE-21895
> URL: https://issues.apache.org/jira/browse/HBASE-21895
> Project: HBase
> Issue Type: Umbrella
> Reporter: Duo Zhang
> Priority: Major
> Attachments: HBASE-21895.master.001.patch
>
>
> As shown in HBASE-21890 , the error prone warnings are truly useful.
> But now, the javac warnings section in the pre commit result is messed up, it
> always reports unrelated warnings. Need to take a look at it.
> And also, we should try out best to clean up the warnings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
