[ 
https://issues.apache.org/jira/browse/HBASE-21895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795304#comment-16795304
 ] 

Kevin Risden commented on HBASE-21895:
--------------------------------------

Thought about this a bit more, prior to upgrading errorprone, the errorprone 
profile wouldn't have worked on JDK 11. This upgrade makes it possible to work 
with JDK 9+ (with changes). Since errorProne is a profile that is an opt in, 
if/when JDK 9+ becomes default build version then should upgrade the errorprone 
profile. Until then, this works as it did previously just with the newer 
version. 

To answer [~stack]'s question, "Is our build changed or it works the same? " - 
Build works the same. Uses the same profile as before just newer version.

> Take more care on the error prone plugin and warnings
> -----------------------------------------------------
>
>                 Key: HBASE-21895
>                 URL: https://issues.apache.org/jira/browse/HBASE-21895
>             Project: HBase
>          Issue Type: Umbrella
>          Components: build
>            Reporter: Duo Zhang
>            Assignee: Kevin Risden
>            Priority: Major
>         Attachments: HBASE-21895.master.001.patch, 
> HBASE-21895.master.002.patch, HBASE-21895.master.003.patch
>
>
> As shown in HBASE-21890 , the error prone warnings are truly useful.
> But now, the javac warnings section in the pre commit result is messed up, it 
> always reports unrelated warnings. Need to take a look at it.
> And also, we should try out best to clean up the warnings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to