[ 
https://issues.apache.org/jira/browse/HBASE-22058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796646#comment-16796646
 ] 

Francis Liu commented on HBASE-22058:
-------------------------------------

I had trouble building the thrift binaries for 0.9.3-1 (the build seems broken) 
but looking at the changes that went into this release:

 

[https://github.com/apache/thrift/commits/a9b748bb0e02a2b6aaa3f39d09ec7f1fa47a0cf4]

 

Theres only 1 relevant commit and it does not seem to be involved in the actual 
code generation. If you guys are okay with this then we can commit this patch 
without regenerating the thrift classes. I've ran the hbase-thrift unit tests 
and they ran fine.

 

cc [~apurtell] 

> backport HBASE-HBASE-21791 (Upgrade thrift dependency to 0.12.0) to 1.4 and 
> 1.3
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-22058
>                 URL: https://issues.apache.org/jira/browse/HBASE-22058
>             Project: HBase
>          Issue Type: Bug
>          Components: Thrift
>            Reporter: Francis Liu
>            Assignee: Francis Liu
>            Priority: Major
>             Fix For: 1.4.10, 1.3.4
>
>         Attachments: HBASE-22058-branch-1.4.patch, 
> HBASE-22058.branch-1.4.001.patch
>
>
> Creating a separate Jira to do the backport since the .thrift files differ 
> between branch-1 and 1.4, 1.3. I backported the change in the pom.xml from 
> branch-1 and regenerated the thrift configs. 
> cc [~apurtell]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to