[
https://issues.apache.org/jira/browse/HBASE-22065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797167#comment-16797167
]
Duo Zhang edited comment on HBASE-22065 at 3/20/19 1:30 PM:
------------------------------------------------------------
On the preconditions, I think check for null is enough, if the list is empty
then just return an empty list.
On the UT
{code}
assertTrue(size == tables.length);
{code}
Use assertEquals.
And I believe the returned TableDescriptors should have the same order with the
provided TableNames, I think we should also assert this, instead of just check
whether we can find the TableDescriptor in the returned list.
Thanks.
was (Author: apache9):
On the preconditions, I think check for null is enough, if the list is empty
then just return an empty list.
On the UT
{quote}
assertTrue(size == tables.length);
{quote}
Use assertEquals.
And I believe the returned TableDescriptors should have the same order with the
provided TableNames, I think we should also assert this, instead of just check
whether we can find the TableDescriptor in the returned list.
Thanks.
> Add listTableDescriptors(List<TableName>) method in AsyncAdmin
> --------------------------------------------------------------
>
> Key: HBASE-22065
> URL: https://issues.apache.org/jira/browse/HBASE-22065
> Project: HBase
> Issue Type: Task
> Components: Admin
> Reporter: Duo Zhang
> Assignee: niuyulin
> Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22065.v1.patch, HBASE-22065.v2.patch
>
>
> Missed this one in AsyncAdmin. Found this when implementing HBASE-21718.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
