[
https://issues.apache.org/jira/browse/HBASE-22058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797736#comment-16797736
]
Francis Liu edited comment on HBASE-22058 at 3/21/19 2:24 AM:
--------------------------------------------------------------
[~apurtell] I took a look at the relevant thrift jira. The release in essence
is a java language only release (release thrift library to maven) with only the
security fix as the change, hence no need to regenerate thrift classes and from
what I understand the package is not expected to build properly.
Here is the comment that seems to sum things up:
https://issues.apache.org/jira/browse/THRIFT-4506?focusedCommentId=16788697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16788697
If this sounds good to you I can update the thrift version dependency and
hardcode the version being checked in fgrep to 0.9.3 instead of
${thrift.version}. FWIW after some hacking I did manage to create the thrift
generator binary but the thrift version wasn't changed as part of the 0.9.3-1
release so it is still shows "Thrift version 0.9.3" when you run "thrift
-version".
was (Author: toffer):
[~apurtell] I took a look at the relevant thrift jira. The release in essence
is a java language only release (release thrift library to maven) hence no need
to regenerate thrift classes and from what I understand the package is not
expected to build properly.
Here is the comment that seems to sum things up:
https://issues.apache.org/jira/browse/THRIFT-4506?focusedCommentId=16788697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16788697
If this sounds good to you I can update the thrift version dependency and
hardcode the version being checked in fgrep to 0.9.3 instead of
${thrift.version}. FWIW after some hacking I did manage to create the thrift
generator binary but the thrift version wasn't changed as part of the 0.9.3-1
release so it is still shows "Thrift version 0.9.3" when you run "thrift
-version".
> backport HBASE-HBASE-21791 (Upgrade thrift dependency to 0.12.0) to 1.4 and
> 1.3
> -------------------------------------------------------------------------------
>
> Key: HBASE-22058
> URL: https://issues.apache.org/jira/browse/HBASE-22058
> Project: HBase
> Issue Type: Bug
> Components: Thrift
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Major
> Fix For: 1.4.10, 1.3.4
>
> Attachments: HBASE-22058-branch-1.4.patch,
> HBASE-22058.branch-1.4.001.patch
>
>
> Creating a separate Jira to do the backport since the .thrift files differ
> between branch-1 and 1.4, 1.3. I backported the change in the pom.xml from
> branch-1 and regenerated the thrift configs.
> cc [~apurtell]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
