[ https://issues.apache.org/jira/browse/HBASE-22114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804573#comment-16804573 ]
Hadoop QA commented on HBASE-22114: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 20m 57s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 1s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:red}-1{color} | {color:red} hbaseanti {color} | {color:red} 0m 0s{color} | {color:red} The patch appears use Hadoop classification instead of HBase. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} branch-1 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 18s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 33s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 26s{color} | {color:green} branch-1 passed with JDK v1.8.0_202 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 20s{color} | {color:green} branch-1 passed with JDK v1.7.0_211 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 6m 19s{color} | {color:green} branch-1 passed {color} | | {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 3m 3s{color} | {color:blue} branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m 30s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 50s{color} | {color:green} branch-1 passed with JDK v1.8.0_202 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 35s{color} | {color:green} branch-1 passed with JDK v1.7.0_211 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 27s{color} | {color:green} the patch passed with JDK v1.8.0_202 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 22s{color} | {color:green} the patch passed with JDK v1.7.0_211 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 12s{color} | {color:red} hbase-server: The patch generated 2 new + 84 unchanged - 12 fixed = 86 total (was 96) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 5s{color} | {color:red} root: The patch generated 2 new + 93 unchanged - 12 fixed = 95 total (was 105) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s{color} | {color:red} hbase-tinylfu-blockcache: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 12 line(s) with tabs. {color} | | {color:red}-1{color} | {color:red} xml {color} | {color:red} 0m 0s{color} | {color:red} The patch has 5 ill-formed XML file(s). {color} | | {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 2m 43s{color} | {color:blue} patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. {color} | | {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m 11s{color} | {color:red} patch has 7 errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 1m 34s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 8s{color} | {color:red} hbase-it in the patch failed with JDK v1.8.0_202. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m 45s{color} | {color:red} root in the patch failed with JDK v1.8.0_202. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 9s{color} | {color:red} hbase-tinylfu-blockcache in the patch failed with JDK v1.7.0_211. {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}160m 6s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 1m 27s{color} | {color:red} The patch generated 5 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}236m 6s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | XML | Parsing Error(s): | | | hbase-common/src/main/resources/hbase-default.xml | | | hbase-it/pom.xml | | | hbase-resource-bundle/src/main/resources/supplemental-models.xml | | | hbase-tinylfu-blockcache/pom.xml | | | pom.xml | | Failed junit tests | hadoop.hbase.regionserver.TestStore | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:61288f8 | | JIRA Issue | HBASE-22114 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12964116/HBASE-22114-branch-1.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml | | uname | Linux 9810a84c2e89 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-1 / b0bc722 | | maven | version: Apache Maven 3.0.5 | | Default Java | 1.7.0_211 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_202 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_211 | | refguide | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/branch-site/book.html | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/diff-checkstyle-hbase-server.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/diff-checkstyle-root.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/diff-checkstyle-hbase-tinylfu-blockcache.txt | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/whitespace-eol.txt | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/whitespace-tabs.txt | | xml | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/xml.txt | | refguide | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/patch-site/book.html | | shadedjars | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/patch-javadoc-hbase-it-jdk1.8.0_202.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/patch-javadoc-root-jdk1.8.0_202.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/patch-javadoc-hbase-tinylfu-blockcache-jdk1.7.0_211.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/artifact/patchprocess/patch-asflicense-problems.txt | | Max. process+thread count | 4605 (vs. ulimit of 10000) | | modules | C: hbase-resource-bundle hbase-common hbase-server hbase-it . hbase-tinylfu-blockcache U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/16579/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 > ------------------------------------------------------- > > Key: HBASE-22114 > URL: https://issues.apache.org/jira/browse/HBASE-22114 > Project: HBase > Issue Type: Sub-task > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Priority: Major > Fix For: 1.5.0 > > Attachments: HBASE-22114-branch-1.patch > > > HBASE-15560 introduces the TinyLFU cache policy for the blockcache. > W-TinyLFU ([research paper|http://arxiv.org/pdf/1512.00727.pdf]) records the > frequency in a counting sketch, ages periodically by halving the counters, > and orders entries by SLRU. An entry is discarded by comparing the frequency > of the new arrival (candidate) to the SLRU's victim, and keeping the one with > the highest frequency. This allows the operations to be performed in O(1) > time and, though the use of a compact sketch, a much larger history is > retained beyond the current working set. In a variety of real world traces > the policy had [near optimal hit > rates|https://github.com/ben-manes/caffeine/wiki/Efficiency]. > The implementation of HBASE-15560 uses several Java 8 idioms, depends on JRE > 8+ type Optional, and has dependencies on libraries compiled with Java 8+ > bytecode. It could be backported to branch-1 but must be made optional both > at compile time and runtime, enabled by the 'build-with-jdk8' build profile. > The TinyLFU policy must go into its own build module. > The blockcache must be modified to load L1 implementation/policy dynamically > at startup by reflection if the policy is "TinyLFU" -- This message was sent by Atlassian JIRA (v7.6.3#76005)