[
https://issues.apache.org/jira/browse/HBASE-5573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234399#comment-13234399
]
stack commented on HBASE-5573:
------------------------------
bq. a zk.ZooKeeper can be created with a zk.Watcher as a parameter for the
constructor. a hb.ZooKeeperWatcher implements the zk.Watcher interface.
Oh, so ZK takes a Watcher Interface or Instance, not necessarily a ZKW (but I
suppose in essence it the same thing). Is ZKW doing everything, not just
Watching? If so, would fixing this help?
On
{code}
hb.ZooKeeperWatcher implements zk.ZooKeeper.
hb.ZooKeeperWatcher contains hb.RecoverableZooKeeper
hb.RecoverableZooKeeper contains zk.ZooKeeper
zk.ZooKeeper contains (hb.ZooKeeperWatcher implements zk.ZooKeeper)
{code}
I see:
ZKW implements ZK.Watcher (I dont' see how it implements ZK)
ZKW has a RZK
This seems way broke Nicolas: "zk.ZooKeeper contains (hb.ZooKeeperWatcher
implements zk.ZooKeeper)"
Ok on ROZK not being a good name. HZK? Thats kinda lame but generic enough
for a base r/w zk'er? Or DumbZK or NoWatchZK. Or InAndOutZK (smile).
> Replace client ZooKeeper watchers by simple ZooKeeper reads
> -----------------------------------------------------------
>
> Key: HBASE-5573
> URL: https://issues.apache.org/jira/browse/HBASE-5573
> Project: HBase
> Issue Type: Improvement
> Components: client, zookeeper
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5573.v1.patch, 5573.v2.patch
>
>
> Some code in the package needs to read data in ZK. This could be done by a
> simple read, but is actually implemented with a watcher. This holds ZK
> resources.
> Fixing this could also be an opportunity to remove the need for the client to
> provide the master address and port.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
