[ 
https://issues.apache.org/jira/browse/HBASE-22150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809430#comment-16809430
 ] 

Sergey Shelukhin commented on HBASE-22150:
------------------------------------------

checkstyle is for inline if, I can fix on commit
+1 will commit tomorrow

> rssStub in HRegionServer is not thread safe and should not directly be used
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-22150
>                 URL: https://issues.apache.org/jira/browse/HBASE-22150
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Bahram Chehrazy
>            Assignee: Bahram Chehrazy
>            Priority: Major
>         Attachments: 
> rssStub-is-not-thread-safe-hence-should-not-be-accessed-directly.patch
>
>
> While working on a patch for HBASE-22060, I noticed that a unit test started 
> failing because region server crashed with NPE during initialization and 
> after aborting the master. It turned out that access to the rssStub was not 
> synchronized.
> The existing code in HRegionServer already takes care of this fact by copying 
> and null checking in most places, but there are a couple ones that are not so 
> careful. Those are in reportForDuty and abort methods. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to