[ 
https://issues.apache.org/jira/browse/HBASE-22070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-22070:
----------------------------------
       Resolution: Fixed
    Fix Version/s: 2.1.5
                   1.5.1
                   2.0.6
                   2.3.0
                   1.3.4
                   1.4.10
                   2.2.0
                   3.0.0
           Status: Resolved  (was: Patch Available)

Pushed the commit to branch-1.3 and up. Skipped branch-1.2 because an RC is in 
progress and this fix in not critical that needs to land there.

Thanks [~VincentChoiCN] for contributing!

> Checking restoreDir in RestoreSnapshotHelper 
> ---------------------------------------------
>
>                 Key: HBASE-22070
>                 URL: https://issues.apache.org/jira/browse/HBASE-22070
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.0.0
>            Reporter: Vincent Choi
>            Assignee: Vincent Choi
>            Priority: Minor
>             Fix For: 3.0.0, 2.2.0, 1.4.10, 1.3.4, 2.3.0, 2.0.6, 1.5.1, 2.1.5
>
>         Attachments: 
> 0001-fixed-a-bug-of-checking-if-restoreDir-is-subDir-of-r.patch, 
> HBASE-22070-master-001.patch, HBASE-22070.patch
>
>
> The restoreDir shouldn't be a sub directory of rootDir. The code check it 
> with a prefix check 
> "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it 
> goes error in some reasonable cases.
> eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I 
> think it's more reasonable to chang the code to 
> "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to