[ 
https://issues.apache.org/jira/browse/HBASE-22070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811684#comment-16811684
 ] 

Hudson commented on HBASE-22070:
--------------------------------

Results for branch branch-1.4
        [build #734 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/734/]: 
(x) *{color:red}-1 overall{color}*
----
details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/734//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/734//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/734//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Checking restoreDir in RestoreSnapshotHelper 
> ---------------------------------------------
>
>                 Key: HBASE-22070
>                 URL: https://issues.apache.org/jira/browse/HBASE-22070
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.0.0
>            Reporter: Vincent Choi
>            Assignee: Vincent Choi
>            Priority: Minor
>             Fix For: 3.0.0, 2.2.0, 1.4.10, 1.3.4, 2.3.0, 2.0.6, 1.5.1, 2.1.5
>
>         Attachments: 
> 0001-fixed-a-bug-of-checking-if-restoreDir-is-subDir-of-r.patch, 
> HBASE-22070-master-001.patch, HBASE-22070.patch
>
>
> The restoreDir shouldn't be a sub directory of rootDir. The code check it 
> with a prefix check 
> "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it 
> goes error in some reasonable cases.
> eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I 
> think it's more reasonable to chang the code to 
> "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to