openinx commented on a change in pull request #126: HBASE-21718 Implement Admin
based on AsyncAdmin
URL: https://github.com/apache/hbase/pull/126#discussion_r273771049
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##########
@@ -1967,10 +1940,8 @@ public void run(Timeout timeout) throws Exception {
LOG.error(
"Unable to remove the failsafe snapshot: " +
failSafeSnapshotSnapshotName,
Review comment:
Could we ignore the err3 here ? I think we shouldn't ignore this. Only
when err3 is null , the ret3 is meaningful, so should have a check before
future.complete(ret3) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
