Apache9 commented on a change in pull request #126: HBASE-21718 Implement Admin
based on AsyncAdmin
URL: https://github.com/apache/hbase/pull/126#discussion_r273776704
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##########
@@ -1967,10 +1940,8 @@ public void run(Timeout timeout) throws Exception {
LOG.error(
"Unable to remove the failsafe snapshot: " +
failSafeSnapshotSnapshotName,
Review comment:
We ignore it in HBaseAdmin either, and if we do not ignore, it could lead to
a UT failure. And in general, the operation here is to delete the fail safe
snapshot, which is used for fail recovery, if we arrive here, it means that we
have already successfully restored the table, so it is not a big deal that we
can not remove the fail safe snapshot, an error log is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
