openinx commented on a change in pull request #135: HBASE-22198 Fix flakey
TestAsyncTableGetMultiThreaded
URL: https://github.com/apache/hbase/pull/135#discussion_r273947775
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableGetMultiThreaded.java
##########
@@ -155,12 +159,23 @@ public String explainFailure() throws Exception {
for (HRegion region :
TEST_UTIL.getHBaseCluster().getRegions(TABLE_NAME)) {
region.compact(true);
-
- //Waiting for compaction to complete and references are cleaned up
+ }
+ for (HRegion region :
TEST_UTIL.getHBaseCluster().getRegions(TABLE_NAME)) {
+ // Waiting for compaction to complete and references are cleaned up
RetryCounter retrier = new RetryCounter(30, 1, TimeUnit.SECONDS);
- while (CompactionState.NONE != admin
-
.getCompactionStateForRegion(region.getRegionInfo().getRegionName())
- && retrier.shouldRetry()) {
+ for (;;) {
+ try {
+ if (admin.getCompactionStateForRegion(
+ region.getRegionInfo().getRegionName()) == CompactionState.NONE)
{
+ break;
+ }
+ } catch (IOException e) {
+ LOG.warn("Failed to query");
Review comment:
So the difference is here ? even if the region is not online, we'll retry
unti exhaust or fail ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
