[
https://issues.apache.org/jira/browse/HBASE-22222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816971#comment-16816971
]
stack commented on HBASE-22222:
-------------------------------
bq. won't this mean that at runtime our thirdparty library will have a
dependency on error prone?
At User API javadoc building time, not at 'runtime' .
bq. What I still don't get is why only userapi reportSet requires the
error_prone_annotations dependency.
I don't know. I'd think adding the thirdparty package to the excludes building
javadoc should have taken care of our issue (but I've not had much luck w/ this
excludes facility building javadoc in the past so not surprised it not working).
bq. Not fully understand here. So we shade the error prone annotation in
hbase-shaded-miscellaneous, but the javadoc plugin will try to load the
unshaded version of error prone annotation?
Pardon me. What [~psomogyi] said. The original error reported by Peter above
complains that the shaded Immutable can't be found (because errorprone is not
in thirdparty -- but because of its package name, references to errorprone
classes are rewritten -- shaded -- in thirdparty). After fixing thirdparty so
as to NOT shade immutable, the javadoc building fails again because errorprone
is not on the classpath at javadoc build time.
bq. Maybe we should just add it back, but do not shade it?
Yeah, thats what the fix proposal does.
[~Apache9]'s change over in HBASE-22233 is better than mine. It is more
generic. Once its in I can roll a thirdparty RC.
> Site build fails after hbase-thirdparty upgrade
> -----------------------------------------------
>
> Key: HBASE-22222
> URL: https://issues.apache.org/jira/browse/HBASE-22222
> Project: HBase
> Issue Type: Bug
> Components: website
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Peter Somogyi
> Assignee: Peter Somogyi
> Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HBASE-22222.patch
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
