[
https://issues.apache.org/jira/browse/HBASE-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-5328:
-------------------------
Attachment: 5328v2.txt
Patch looks fat but its mostly comments, javadoc, and new Tests and Test
facility.
{code}
M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
Make this class public so its waitForRoot(long) can be used by HMaster.
Remove the stalling waitForRoot no arg.
M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
Javadoc. Add check if stopped flag cycling waiting on assignment.
M src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Moved check if schema change flag out to a method rather than
have it on tail of constructor.
Moved other initialization stuff like get of assignment manager
and server manager out into methods so could be intercepted by
tests and mocking.
Change how we wait on root so we sleep 100ms at a time and always
check stopped flag rather than block for ever.
Added more checking if stopped flag.
Added flag for when rpc server is up, mostly for tests.
M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
Unused import.
M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
Comment.
M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
Remove unused code.
M src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
Change how we wait on root. DOn't use removed method.
A src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
Added a mock regionserver used faking out master. Later this may
become more generally useable. Can move it up out of this package
then but for now just used by TestMasterNoCluster.
M src/test/java/org/apache/hadoop/hbase/master/Mocking.java
Mocking utilities used only by a few of the classes in this package.
Later may be generally useful. Will move it then.
M src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
Use new Mocking utilities. Move method from here out to Mocking.
M src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java
Test stopping master on initialization as well as master failover and
startup sequence.
{code}
> Small changes to Master to make it more testable
> ------------------------------------------------
>
> Key: HBASE-5328
> URL: https://issues.apache.org/jira/browse/HBASE-5328
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 5328.txt, 5328v2.txt
>
>
> Here are some small changes in Master that make it more testable. Included
> tests stand up a Master and then fake it into thinking that three
> regionservers are registering making master assign root and meta, etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
