[
https://issues.apache.org/jira/browse/HBASE-22254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819539#comment-16819539
]
HBase QA commented on HBASE-22254:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
50s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
54s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 2m
43s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
16s{color} | {color:red} hbase-zookeeper in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
44s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
26s{color} | {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 16s{color} |
{color:red} hbase-zookeeper in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 44s{color} |
{color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 26s{color} |
{color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 16s{color}
| {color:red} hbase-zookeeper in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 44s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 26s{color}
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} The patch fails to run checkstyle in hbase-zookeeper
{color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
25s{color} | {color:red} hbase-server: The patch generated 4 new + 216
unchanged - 3 fixed = 220 total (was 219) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 3m
40s{color} | {color:red} patch has 212 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
37s{color} | {color:red} The patch causes 212 errors with Hadoop v2.7.4.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
19s{color} | {color:red} The patch causes 212 errors with Hadoop v3.0.0.
{color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m
16s{color} | {color:red} hbase-zookeeper in the patch failed. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m
42s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m
24s{color} | {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
15s{color} | {color:red} hbase-zookeeper in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
43s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
23s{color} | {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
13s{color} | {color:red} hbase-zookeeper in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
41s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
44s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 16s{color}
| {color:red} hbase-zookeeper in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 44s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 25s{color}
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
41s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 57m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22254 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12966143/HBASE-22254.patch |
| Optional Tests | dupname asflicense cc unit hbaseprotoc javac javadoc
findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 7cdacdb05825 4.4.0-145-generic #171-Ubuntu SMP Tue Mar 26
12:43:40 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / cc9d401015 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-mvninstall-root.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-compile-hbase-zookeeper.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-compile-hbase-server.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-compile-hbase-rsgroup.txt
|
| cc |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-compile-hbase-zookeeper.txt
|
| cc |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-compile-hbase-server.txt
|
| cc |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-compile-hbase-rsgroup.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-compile-hbase-zookeeper.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-compile-hbase-server.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-compile-hbase-rsgroup.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess//testptch/patchprocess/maven-patch-checkstyle-hbase-zookeeper.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| shadedjars |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-shadedjars.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-javac-2.7.4.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-javac-3.0.0.txt
|
| hbaseprotoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-hbaseprotoc-hbase-zookeeper.txt
|
| hbaseprotoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-hbaseprotoc-hbase-server.txt
|
| hbaseprotoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-hbaseprotoc-hbase-rsgroup.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-findbugs-hbase-zookeeper.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-findbugs-hbase-server.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-findbugs-hbase-rsgroup.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-javadoc-hbase-zookeeper.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-unit-hbase-zookeeper.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/artifact/patchprocess/patch-unit-hbase-rsgroup.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/testReport/ |
| Max. process+thread count | 95 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-zookeeper hbase-server hbase-rsgroup
U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/102/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> refactor and improve decommissioning logic
> ------------------------------------------
>
> Key: HBASE-22254
> URL: https://issues.apache.org/jira/browse/HBASE-22254
> Project: HBase
> Issue Type: Improvement
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Major
> Attachments: HBASE-22254.patch
>
>
> Making some changes needed to support better decommissioning on large
> clusters and with container mode; to test those and add clarify I moved parts
> of decommissioning logic from HMaster, Draining tracker, and ServerManager
> into a separate class.
> Features added/improvements:
> 1) More resilient off-loading; right now off-loading fails for a subset of
> regions in case of a single region failure; is never done on master restart,
> etc.
> 2) Option to kill RS after off-loading (good for container mode HBase, e.g.
> on YARN).
> 3) Option to specify machine names only to decommission, for the API to be
> usable for an external system that doesn't care about HBase server names, or
> e.g. multiple RS in containers on the same node.
> 4) Option to replace existing decommissioning list instead of adding to it
> (the same; to avoid additionally remembering what was previously sent to
> HBase).
> 5) Tests, comments ;)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)