[ https://issues.apache.org/jira/browse/HBASE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235013#comment-13235013 ]
Jean-Daniel Cryans commented on HBASE-3134: ------------------------------------------- I found one corner case: # start replication with a peer # insert some data # kill the peer # disable replication # start the peer The issue is that when the peer is restarted the region servers will be able to replicate the batch they are currently trying to send. Here's the log: {noformat} 2012-03-21 20:40:14,775 INFO org.apache.hadoop.hbase.replication.regionserver.ReplicationSource: Slave cluster looks down: Failed setting up proxy interface org.apache.hadoop.hbase.ipc.HRegionInterface to sv4r9s44/10.4.9.44:62023 after attempts=1 2012-03-21 20:40:15,774 DEBUG org.apache.hadoop.hbase.replication.regionserver.ReplicationSource: Since we are unable to replicate, sleeping 1000 times 9 2012-03-21 20:40:24,786 DEBUG org.apache.hadoop.hbase.replication.regionserver.ReplicationSource: Replicating 149 2012-03-21 20:40:30,826 INFO org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager: Going to report log #sv4r8s38%2C62023%2C1332361576338.1332361577015 for position 303630357 in hdfs://sv4r11s38:9100/hbase/.logs/sv4r8s38,62023,1332361576338/sv4r8s38%2C62023%2C1332361576338.1332361577015 2012-03-21 20:40:30,830 DEBUG org.apache.hadoop.hbase.replication.regionserver.ReplicationSource: Replicated in total: 149 2012-03-21 20:40:30,830 DEBUG org.apache.hadoop.hbase.replication.regionserver.ReplicationSource: Replication is disabled, sleeping 1000 times 1 {noformat} Right now {{shipEdits}} won't let you throw an {{Exception}} as it catches everything, so we could change that or we could change the loop at the end of the method to stay in there until replication is re-enabled (at which point the edits will be sent directly). I'm also opened to other suggestions. Another thing I saw is that both {{enable_peer}} and {{disable_peer}} in the shell still show "CURRENTLY UNSUPPORTED" in their help. I'm sorry it took me so long to get to this jira. > [replication] Add the ability to enable/disable streams > ------------------------------------------------------- > > Key: HBASE-3134 > URL: https://issues.apache.org/jira/browse/HBASE-3134 > Project: HBase > Issue Type: New Feature > Components: replication > Reporter: Jean-Daniel Cryans > Assignee: Teruyoshi Zenmyo > Priority: Minor > Labels: replication > Fix For: 0.94.0 > > Attachments: 3134-v2.txt, 3134-v3.txt, 3134.txt, HBASE-3134.patch, > HBASE-3134.patch, HBASE-3134.patch, HBASE-3134.patch > > > This jira was initially in the scope of HBASE-2201, but was pushed out since > it has low value compared to the required effort (and when want to ship > 0.90.0 rather soonish). > We need to design a way to enable/disable replication streams in a > determinate fashion. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira