openinx commented on a change in pull request #163: HBASE-21995 Add a 
coprocessor to set HDFS ACL for hbase granted user
URL: https://github.com/apache/hbase/pull/163#discussion_r276895902
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java
 ##########
 @@ -314,12 +316,24 @@ private FSDataInputStream tryOpen() throws IOException {
           return(in);
         } catch (FileNotFoundException e) {
           // Try another file location
+        } catch (AccessControlException e) {
 
 Review comment:
   Here, I prefer to simplify the logic as a small method:
   1. remember the thrown exception as e;
   2. if notfound or accessControl exception, continue to try another file;
   3.  if still not find an right file.  then throw the e. 
   Please consider this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to