[ 
https://issues.apache.org/jira/browse/HBASE-22273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822384#comment-16822384
 ] 

puleya7 commented on HBASE-22273:
---------------------------------

 
{code:java}
boolean queueTooLong = (qTime > warnQueueTime && warnQueueTime > -1);
if (tooSlow || tooLarge || queueTooLong) {
  logResponse();
}{code}
Looks bad.:)

 

If slow queue happened, there won't be only one request, Most logs will be 
useless.

> Include queuetime in the condition of reponseTooSlow
> ----------------------------------------------------
>
>                 Key: HBASE-22273
>                 URL: https://issues.apache.org/jira/browse/HBASE-22273
>             Project: HBase
>          Issue Type: Improvement
>          Components: logging, regionserver
>            Reporter: puleya7
>            Priority: Minor
>         Attachments: HBASE-22273.patch
>
>
> I think the condition of responseTooSlow should include queuetime, 
> occasionally requests queued too much due to bad callqueue config, but there 
> is no slow log because processingTime is short.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to