infraio commented on a change in pull request #172: HBASE-22261 Make use of 
ClusterStatusListener for async client
URL: https://github.com/apache/hbase/pull/172#discussion_r277153169
 
 

 ##########
 File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
 ##########
 @@ -133,6 +139,31 @@ public AsyncConnectionImpl(Configuration conf, 
AsyncRegistry registry, String cl
     } else {
       nonceGenerator = NO_NONCE_GENERATOR;
     }
+    ClusterStatusListener listener = null;
+    if (conf.getBoolean(STATUS_PUBLISHED, STATUS_PUBLISHED_DEFAULT)) {
+      // XXX: this maybe a blocking operation, better to create it outside the 
constructor and pass
 
 Review comment:
   XXX ==> TODO?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to