ndimiduk commented on a change in pull request #157: HBASE-16002 Made
constructors of DataType subclasses public
URL: https://github.com/apache/hbase/pull/157#discussion_r277206395
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedBlob.java
##########
@@ -32,7 +32,7 @@
public static final OrderedBlob ASCENDING = new OrderedBlob(Order.ASCENDING);
public static final OrderedBlob DESCENDING = new
OrderedBlob(Order.DESCENDING);
- protected OrderedBlob(Order order) {
+ public OrderedBlob(Order order) {
Review comment:
If you think deprecating the static constants is appropriate, then I have no
objection. There's always a balance between minimizing our supported surface
area and downstream convenience. I've not followed things very closely as of
late, but it seems we're on a pretty strong kick to deprecate/drop old
interfaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
