[
https://issues.apache.org/jira/browse/HBASE-22236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822933#comment-16822933
]
Duo Zhang commented on HBASE-22236:
-----------------------------------
If we want to follow the other methods in RegionLocations, the code should be
{code}
if (noChange) {
retirm this;
} else if (hasNonNullElement) {
return new RegionLocations;
} else {
return null;
}
{code}
But since we always create the new array, so I do not think it is a big deal to
also create a new RegionLocations.
> AsyncNonMetaRegionLocator should not cache HRegionLocation with null location
> -----------------------------------------------------------------------------
>
> Key: HBASE-22236
> URL: https://issues.apache.org/jira/browse/HBASE-22236
> Project: HBase
> Issue Type: Bug
> Components: asyncclient
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22236-v1.patch, HBASE-22236-v2.patch,
> HBASE-22236.patch
>
>
> https://builds.apache.org/job/HBase-Flaky-Tests/job/master/2992/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestAsyncTableGetMultiThreaded-output.txt/*view*/
> After this line
> {noformat}
> 2019-04-14 04:44:41,736 INFO [PEWorker-12]
> procedure2.ProcedureExecutor(1410): Finished pid=117, state=SUCCESS,
> hasLock=false; TransitRegionStateProcedure table=hbase:meta,
> region=1588230740, REOPEN/MOVE in 2.0690sec
> {noformat}
> Seems we just do nothing until the test is timed out.
> And there is no main thread in the output hanging thread, which is a bit
> strange, although all the get threads are hanging there.
> Let me add some logs for better debugging first.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
