[
https://issues.apache.org/jira/browse/HBASE-21593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823592#comment-16823592
]
stack commented on HBASE-21593:
-------------------------------
I don't get setting closing to 'false' when it seems like we are indeed closing
at this stage (Did you see the comment by [~Jan Hentschel] up on the PR?)
> closing flags show be set false in HRegion
> ------------------------------------------
>
> Key: HBASE-21593
> URL: https://issues.apache.org/jira/browse/HBASE-21593
> Project: HBase
> Issue Type: Bug
> Reporter: xiaolerzheng
> Assignee: Xu Cang
> Priority: Minor
> Attachments: HBASE-21593.branch-1.001.patch,
> image-2018-12-13-16-04-51-892.png, image-2018-12-13-16-05-09-246.png,
> image-2018-12-13-16-05-36-404.png
>
>
> in HRegion.java
>
>
> 1429 // block waiting for the lock for closing
> 1430 lock.writeLock().lock();
> 1431 this.closing.set(true);
> 1432 status.setStatus("Disabling writes for close");
>
> ....
>
>
> 1557 } finally {
> {color:#FF0000} //should here add {color}
> {color:#FF0000} this.closing.set(false); {color}
> 1558 lock.writeLock().unlock();
> 1559 }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
