[
https://issues.apache.org/jira/browse/HBASE-22298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825300#comment-16825300
]
stack commented on HBASE-22298:
-------------------------------
[~zghaobac] The nightlies were failing w/o this since about April 18th. With
this back in place, #208 from last night passed. Failures are just flakies now.
https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-2.2/
This fixed an errorprone complaint that found legit issue. If tests are
passing for you w/o this fix, then go ahead w/ RC2 I'd say.
Were you able to use the build script to generate the RC2?
> branch-2.2 nightly fails "[ForOverride] Method annotated @ForOverride must
> have protected or package-private visibility"
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-22298
> URL: https://issues.apache.org/jira/browse/HBASE-22298
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22298.branch-2.2.001.patch
>
>
> The change to use guava service happened a long time ago but we errorprone
> only complains now... update?
> {code}
> ....
> [INFO] 97 warnings
> [INFO] -------------------------------------------------------------
> [INFO] -------------------------------------------------------------
> [ERROR] COMPILATION ERROR :
> [INFO] -------------------------------------------------------------
> [ERROR]
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ClusterSchemaServiceImpl.java:[60,27]
> error: [ForOverride] Method annotated @ForOverride must have protected or
> package-private visibility
> (see https://errorprone.info/bugpattern/ForOverride)
> [INFO] 1 error
> {code}
> See https://errorprone.info/bugpattern/ForOverride
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)