[
https://issues.apache.org/jira/browse/HBASE-22054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825516#comment-16825516
]
Josh Elser commented on HBASE-22054:
------------------------------------
{quote}except TestCompactionLifeCycleTracker#testSpaceQuotaViolation() which
assumes that compaction wouldn't happen with null user in case of space quota
violation. Hence I think this test can be ignored/removed completely.
{quote}
Yeah, that makes sense. I think the change to allow system-issued compactions
and superuser-issued compactions is good.
{code:java}
+ } catch (Exception e) {
+ // Unexpected Exception.
+ LOG.debug("Super User: Caught Exception: " + e.getMessage());
{code}
How about just {{LOG.debug("message", e)}} instead of the {{e.getMessage()}}.
{code:java}
+ try {
+ Superusers.initialize(newConf);
+ } catch (IOException e) {
+ LOG.debug("Failed to initialize SuperUsers on reloading of the
configuration");
+ }{code}
Why might this fail? Should this be a {{WARN}} and not a {{DEBUG}}?
> Space Quota: Compaction is not working for super user in case of
> NO_WRITES_COMPACTIONS
> --------------------------------------------------------------------------------------
>
> Key: HBASE-22054
> URL: https://issues.apache.org/jira/browse/HBASE-22054
> Project: HBase
> Issue Type: Bug
> Reporter: Ajeet Rai
> Assignee: Sakthi
> Priority: Minor
> Labels: Quota, Space
> Attachments: hbase-22054.master.001.patch,
> hbase-22054.master.002.patch, hbase-22054.master.003.patch,
> hbase-22054.master.004.patch
>
>
> Space Quota: Compaction is not working for super user. Compaction command is
> issued successfully at client but actually compaction is not happening.
> In debug log below message is printed:
> as an active space quota violation policy disallows compaction.
> Reference:
>
> [https://lists.apache.org/thread.html/d09aa7abaacf1f0be9d59fa9260515ddc0c17ac0aba9cc0f2ac569bf@%3Cuser.hbase.apache.org%3E]
> Actually in requestCompactionInternal method of CompactSplit class ,there is
> no check for super user and compcations are disallowed
> {noformat}
> RegionServerSpaceQuotaManager spaceQuotaManager =
> this.server.getRegionServerSpaceQuotaManager();
> if (spaceQuotaManager != null &&
>
> spaceQuotaManager.areCompactionsDisabled(region.getTableDescriptor().getTableName()))
> {
> String reason = "Ignoring compaction request for " + region +
> " as an active space quota violation " + " policy disallows
> compactions.";
> tracker.notExecuted(store, reason);
> completeTracker.completed(store);
> LOG.debug(reason);
> return;
> }
> {noformat}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
