[
https://issues.apache.org/jira/browse/HBASE-22314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826249#comment-16826249
]
HBase QA commented on HBASE-22314:
----------------------------------
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
38s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
30s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 35s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
13s{color} | {color:green} hbase-shaded-client-byo-hadoop in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 59s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/187/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22314 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12967036/HBASE-22314.0.patch |
| Optional Tests | dupname asflicense javac javadoc unit shadedjars
hadoopcheck xml compile |
| uname | Linux 1d928012bca5 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ec36372649 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/187/testReport/ |
| Max. process+thread count | 85 (vs. ulimit of 10000) |
| modules | C: hbase-shaded/hbase-shaded-client-byo-hadoop U:
hbase-shaded/hbase-shaded-client-byo-hadoop |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/187/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> shaded byo-hadoop client should list needed hadoop modules as provided scope
> to avoid inclusion of unnecessary transitive depednencies
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-22314
> URL: https://issues.apache.org/jira/browse/HBASE-22314
> Project: HBase
> Issue Type: Bug
> Components: hadoop2, hadoop3, shading
> Affects Versions: 2.1.0, 2.0.0, 2.2.0, 2.3.0
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.1.5, 2.2.1
>
> Attachments: HBASE-22314.0.patch
>
>
> attempting to build against current hadoop trunk for HBASE-22087 shows that
> hte byo-hadoop client is trying to package transitive dependencies from the
> hadoop dependencies that we expressly say we don't need to bring with us.
> it's because we don't list those modules as provided, so all of their
> transitives are also in compile scope. The shading module does simple
> filtering when excluding things in a given scope, it doesn't e.g. make sure
> to also exclude the transitive dependencies of things it keeps out.
> since we don't want to list all the transitive dependencies of hadoop in our
> shading exclusion, we should list the needed hadoop modules as provided.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
