openinx commented on a change in pull request #191: HBASE-22036 Rewrite TestScannerHeartbeatMessages URL: https://github.com/apache/hbase/pull/191#discussion_r279174431
########## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/ScanPerNextResultScanner.java ########## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.client; + +import java.io.IOException; +import java.io.InterruptedIOException; +import java.util.ArrayDeque; +import java.util.Queue; +import org.apache.hadoop.hbase.client.metrics.ScanMetrics; +import org.apache.yetus.audience.InterfaceAudience; + +import org.apache.hbase.thirdparty.com.google.common.base.Throwables; + +/** + * A ResultScanner which will only send request to RS when there are no cached results when calling + * next, just like the ResultScanner in the old time. Mainly used for writing UTs, that we can + * control when to send request to RS. The default ResultScanner implementation will fetch in + * background. + */ [email protected] +public class ScanPerNextResultScanner implements ResultScanner, AdvancedScanResultConsumer { Review comment: Seems this class is only used for testing ? I prefer to move this into test package, or other future packages will use this ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
